ptupitsyn commented on a change in pull request #7616: IGNITE-12853: Introduced
features for the thin client protocol
URL: https://github.com/apache/ignite/pull/7616#discussion_r409462084
##########
File path:
modules/platforms/dotnet/Apache.Ignite.Core/Cache/Configuration/QueryEntity.cs
##########
@@ -229,12 +229,31 @@ string IQueryEntityInternal.GetAlias(string fieldName)
return _aliasMap.TryGetValue(fieldName, out res) ? res : null;
}
+ /// <summary>
+ /// Initializes a new instance of the <see cref="QueryEntity"/> class.
+ /// </summary>
+ /// <param name="reader">The reader.</param>
+ internal QueryEntity(IBinaryRawReader reader)
+ {
+ Read(reader, ClientSocket.CurrentProtocolVersion);
+ }
+
/// <summary>
/// Initializes a new instance of the <see cref="QueryEntity"/> class.
/// </summary>
/// <param name="reader">The reader.</param>
/// <param name="srvVer">Server version.</param>
internal QueryEntity(IBinaryRawReader reader, ClientProtocolVersion
srvVer)
+ {
+ Read(reader, srvVer);
+ }
+
+ /// <summary>
+ /// Reads an instance of the <see cref="QueryEntity"/> class.
+ /// </summary>
+ /// <param name="reader">The reader.</param>
+ /// <param name="srvVer">Server version.</param>
+ internal void Read(IBinaryRawReader reader, ClientProtocolVersion
srvVer)
Review comment:
Ideally we should get rid of `ClientProtocolVersion` here and separate Thin
and Thick logic completely. Thin client config logic should be in
`ClientCacheConfigurationSerializer`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
