[GitHub] [ignite] sk0x50 commented on a change in pull request #7613: IGNITE-12821 Add check size into validate_indexes

[GitBox]

sk0x50 commented on a change in pull request #7613: IGNITE-12821 Add check size 
into validate_indexes
URL: https://github.com/apache/ignite/pull/7613#discussion_r407257408
 
 

 ##########
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/visor/verify/VisorValidateIndexesTaskArg.java
 ##########
 @@ -101,49 +122,47 @@ public int getCheckFirst() {
     }
 
     /**
-     * @return checkThrough.
+     * Returns whether to check that index size and cache size are same.
+     *
+     * @return {@code true} if need check that index size and cache size
+     *      are same.
      */
-    public int getCheckThrough() {
-        return checkThrough;
+    public boolean checkSizes() {
+        return checkSizes;
     }
 
     /** {@inheritDoc} */
     @Override protected void writeExternalData(ObjectOutput out) throws 
IOException {
-        U.writeCollection(out, caches);
+        writeCollection(out, caches);
         out.writeInt(checkFirst);
         out.writeInt(checkThrough);
-        U.writeCollection(out, nodes);
+        writeCollection(out, nodes);
         out.writeBoolean(checkCrc);
+        out.writeBoolean(checkSizes);
     }
 
     /** {@inheritDoc} */
     @Override protected void readExternalData(byte protoVer, ObjectInput in) 
throws IOException, ClassNotFoundException {
-        caches = U.readSet(in);
+        caches = readSet(in);
 
         if (protoVer > V1) {
             checkFirst = in.readInt();
             checkThrough = in.readInt();
         }
-        else {
-            checkFirst = -1;
-            checkThrough = -1;
-        }
 
         if (protoVer > V2)
-            nodes = U.readSet(in);
+            nodes = readSet(in);
 
-        if (protoVer >= V6)
+        if (protoVer > V5)
             checkCrc = in.readBoolean();
-    }
 
-    /** Set checkCrc */
-    protected void checkCrc(boolean checkCrc) {
-        this.checkCrc = checkCrc;
+        if (protoVer > V6)
+            checkSizes = in.readBoolean();
     }
 
     /** {@inheritDoc} */
     @Override public byte getProtocolVersion() {
-        return V6;
+        return V7;
 
 Review comment:
   Do we really need to try to support the rolling upgrade here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services