sk0x50 commented on a change in pull request #7613: IGNITE-12821 Add check size
into validate_indexes
URL: https://github.com/apache/ignite/pull/7613#discussion_r407262973
##########
File path:
modules/indexing/src/main/java/org/apache/ignite/internal/visor/verify/ValidateIndexesClosure.java
##########
@@ -206,53 +230,55 @@ private VisorValidateIndexesJobResult call0() {
List<Future<Map<PartitionKey, ValidateIndexesPartitionResult>>>
procPartFutures = new ArrayList<>();
List<Future<Map<String, ValidateIndexesPartitionResult>>>
procIdxFutures = new ArrayList<>();
+ List<T3<CacheGroupContext, GridDhtLocalPartition, Future<CacheSize>>>
cacheSizeFutures = new ArrayList<>();
+ List<T3<GridCacheContext, Index, Future<T2<Throwable, Long>>>>
idxSizeFutures = new ArrayList<>();
Review comment:
Perhaps, it would be nice to have a dedicated class for these tuples. To be
honest, the following line looks weird to me.
> cacheSizeFutures.get(curCacheSize).get3().get();
For instance:
```
class PartitionSizeFuture {
public CacheGroupContext groupContext();
public GridLocalPartition partition();
public CacheSize size();
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
