ascherbakoff commented on a change in pull request #7705:
URL: https://github.com/apache/ignite/pull/7705#discussion_r468551851
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java
##########
@@ -1786,12 +1892,15 @@ public boolean
compatibleWith(GridDhtPreloaderAssignments newAssignments) {
Set<Integer> p1 = new HashSet<>();
// Not compatible if a supplier has left.
- for (ClusterNode node : rebalancingParts.keySet()) {
- if
(!grp.cacheObjectContext().kernalContext().discovery().alive(node))
+ for (UUID nodeId : fullRebalancingParts.keySet()) {
Review comment:
You have broken chain compatibility logic.
Both full and historical suppliers must be checked.
Can you revert this change and keep rebalancingParts untouched ?
fullRebalancingParts and histRebalancingParts also should be removed
completely, because they are not needed, see details below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
