ascherbakoff commented on a change in pull request #7705:
URL: https://github.com/apache/ignite/pull/7705#discussion_r468560521



##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java
##########
@@ -1641,17 +1723,41 @@ private synchronized void partitionDone(UUID nodeId, 
int p, boolean own) {
             assert rmvd : "Partition already done [grp=" + 
grp.cacheOrGroupName() + ", fromNode=" + nodeId +
                 ", part=" + p + ", left=" + parts + "]";
 
-                if (rmvd)
-                    partitionsLeft.decrementAndGet();
+            if (rmvd)
+                partitionsLeft.decrementAndGet();
 
             if (parts.isEmpty()) {
                 int remainingRoutines = remaining.size() - 1;
 
-                U.log(log, "Completed " + ((remainingRoutines == 0 ? "(final) 
" : "") +
+                int fullParts = fullRebalancingParts.get(nodeId).size();
+                int histParts = histRebalancingParts.get(nodeId).size();

Review comment:
       Let's get rid of fullRebalancingParts and histRebalancingParts. For 
example, you can get a number of full partitions for a node using information 
provided in `fut.rebalancingParts` and `fut.historical` using the filter like:
   `rebalancingParts.get(nodeId).stream().filter(p -> 
!historical.contains(p)).count();`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to