dmagda commented on a change in pull request #8207:
URL: https://github.com/apache/ignite/pull/8207#discussion_r483201088
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/ExchangeContext.java
##########
@@ -37,7 +38,8 @@
*
*/
public class ExchangeContext {
- /** */
+ /** Enables exchange compatibility with protocol version 1. */
+ @SystemProperty(value = "Enables exchange compatibility with protocol
version 1.")
Review comment:
I would say "Enables the compatibility mode for the exchange protocol of
version 1."
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java
##########
@@ -138,7 +139,9 @@
/** */
public static final GridCacheAtomicVersionComparator ATOMIC_VER_COMPARATOR
= new GridCacheAtomicVersionComparator();
- /** Property name for entry lock timeout. */
+ /** Property name for entry lock timeout in milliseconds. Default is 1000.
*/
Review comment:
I would say "Sets the entry's lock timeout in milliseconds. Defaults to
1000 milliseconds"
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java
##########
@@ -190,12 +191,15 @@
@SuppressWarnings({"unchecked",
"NonPrivateFieldAccessedInSynchronizedContext"})
public class GridCacheDatabaseSharedManager extends
IgniteCacheDatabaseSharedManager {
/** */
+ @SystemProperty(value = "Skip IO sync on checkpoint.")
public static final String IGNITE_PDS_CHECKPOINT_TEST_SKIP_SYNC =
"IGNITE_PDS_CHECKPOINT_TEST_SKIP_SYNC";
- /** */
+ /** Skip checkpoint on node stop flag. */
+ @SystemProperty(value = "Skip checkpoint on node stop flag.")
Review comment:
"Sets the flag controlling of a checkpoint needs to be skipped during a
node termination. Defaults to false."
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java
##########
@@ -190,12 +191,15 @@
@SuppressWarnings({"unchecked",
"NonPrivateFieldAccessedInSynchronizedContext"})
public class GridCacheDatabaseSharedManager extends
IgniteCacheDatabaseSharedManager {
/** */
+ @SystemProperty(value = "Skip IO sync on checkpoint.")
Review comment:
"Sets the flag controlling if the I/O sync needs to be skipped on a
checkpoint. Defaults to`false`"
##########
File path: modules/core/src/main/java/org/apache/ignite/SystemProperty.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite;
+
+import java.lang.annotation.Documented;
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/** Ignite system property info. */
+@Documented
+@Retention(RetentionPolicy.RUNTIME)
+@Target({ElementType.FIELD})
+public @interface SystemProperty {
+ /** Description. */
+ String value();
Review comment:
How about renaming `value` to `descr` (stands for description) and
adding the `default` property? Then the property will be used this way in the
code
`@SystemProperty(descr = "Sets the entry's lock timeout in milliseconds",
default = "1000 millis", type = Long.class)`
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/deployment/local/LocalDeploymentSpi.java
##########
@@ -69,6 +70,7 @@
@IgnoreIfPeerClassLoadingDisabled
public class LocalDeploymentSpi extends IgniteSpiAdapter implements
DeploymentSpi {
/** Enables additional check for resource name on resources removal. */
+ @SystemProperty(value = "Enables additional check for resource name on
resources removal.")
Review comment:
Enables an additional check of a resource name on resources removal
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/util/portscanner/GridJmxPortFinder.java
##########
@@ -25,12 +25,14 @@
import java.net.UnknownHostException;
import java.nio.channels.FileLock;
import org.apache.ignite.IgniteSystemProperties;
+import org.apache.ignite.SystemProperty;
/**
* Ignite port scanner.
*/
public class GridJmxPortFinder {
/** Environment variable for overriding JMX port. */
+ @SystemProperty(value = "JMX port.", type = Integer.class)
Review comment:
"Sets a JMX port for the Ignite instance. Defaults to X."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
