NSAmelchev commented on a change in pull request #8207:
URL: https://github.com/apache/ignite/pull/8207#discussion_r484539843
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java
##########
@@ -291,6 +292,21 @@
/** Default connection recovery timeout in ms. */
public static final long DFLT_CONNECTION_RECOVERY_TIMEOUT =
IgniteConfiguration.DFLT_FAILURE_DETECTION_TIMEOUT;
+ /** @see
IgniteSystemProperties#IGNITE_DISCOVERY_CLIENT_RECONNECT_HISTORY_SIZE */
+ public static final int DFLT_DISCOVERY_CLIENT_RECONNECT_HISTORY_SIZE = 512;
+
+ /** @see IgniteSystemProperties#IGNITE_NODE_IDS_HISTORY_SIZE */
+ public static final int DFLT_NODE_IDS_HISTORY_SIZE = 50;
+
+ /** @see IgniteSystemProperties#IGNITE_DISCO_FAILED_CLIENT_RECONNECT_DELAY
*/
+ public static final int DFLT_DISCO_CLIENT_RECONNECT_DELAY = 10_000;
Review comment:
I think it is better to use the same name as the prop's name:
`DFLT_DISCO_FAILED_CLIENT_RECONNECT_DELAY`
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cluster/ClusterProcessor.java
##########
@@ -125,6 +125,12 @@
/** Active baseline nodes count metric name. */
public static final String ACTIVE_BASELINE_NODES = "ActiveBaselineNodes";
+ /** @see IgniteSystemProperties#IGNITE_UPDATE_NOTIFIER */
+ public static final boolean DFLT_IGNITE_UPDATE_NOTIFIER = true;
Review comment:
typo: `DFLT_UPDATE_NOTIFIER`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
