Mmuzaf commented on a change in pull request #8207:
URL: https://github.com/apache/ignite/pull/8207#discussion_r485549448
##########
File path:
modules/core/src/main/java/org/apache/ignite/IgniteSystemProperties.java
##########
@@ -515,69 +774,101 @@
* @deprecated Since version 2.8.
*/
@Deprecated
+ @SystemProperty("Force all SQL queries to be processed lazily regardless
of what clients request")
public static final String IGNITE_SQL_FORCE_LAZY_RESULT_SET =
"IGNITE_SQL_FORCE_LAZY_RESULT_SET";
/** Disable SQL system views. */
+ @SystemProperty("Disables SQL system views")
public static final String IGNITE_SQL_DISABLE_SYSTEM_VIEWS =
"IGNITE_SQL_DISABLE_SYSTEM_VIEWS";
/** SQL retry timeout. */
+ @SystemProperty(value = "SQL retry timeout in milliseconds", type =
Long.class, defaults = "30 seconds")
public static final String IGNITE_SQL_RETRY_TIMEOUT =
"IGNITE_SQL_RETRY_TIMEOUT";
/** Enable backward compatible handling of UUID through DDL. */
+ @SystemProperty("Enables backward compatible handling of UUID through DDL")
public static final String IGNITE_SQL_UUID_DDL_BYTE_FORMAT =
"IGNITE_SQL_UUID_DDL_BYTE_FORMAT";
Review comment:
Should we consider moving the default value to the constant like for
other constant does?
`CommandProcessor:157`
```
IgniteSystemProperties.getBoolean(IgniteSystemProperties.IGNITE_SQL_UUID_DDL_BYTE_FORMAT,
false);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
