NSAmelchev commented on a change in pull request #8207:
URL: https://github.com/apache/ignite/pull/8207#discussion_r485511115
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/deployment/local/LocalDeploymentSpi.java
##########
@@ -69,6 +70,7 @@
@IgnoreIfPeerClassLoadingDisabled
public class LocalDeploymentSpi extends IgniteSpiAdapter implements
DeploymentSpi {
/** Enables additional check for resource name on resources removal. */
+ @SystemProperty(value = "Enables an additional check of a resource name on
resources removal.")
Review comment:
Dot is unnecessary.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/util/OffheapReadWriteLock.java
##########
@@ -34,13 +35,27 @@
* </pre>
*/
public class OffheapReadWriteLock {
+ /** @see #IGNITE_OFFHEAP_RWLOCK_SPIN_COUNT */
+ public static final int DFLT_OFFHEAP_RWLOCK_SPIN_COUNT = 32;
+
+ /** */
+ @SystemProperty(value = "Count spin lock iterations before fallback to
block", type = Long.class,
+ defaults = "" + DFLT_OFFHEAP_RWLOCK_SPIN_COUNT)
+ public static final String IGNITE_OFFHEAP_RWLOCK_SPIN_COUNT =
"IGNITE_OFFHEAP_RWLOCK_SPIN_COUNT";
+
+ /** */
+ @SystemProperty(value = "OffheapReadWriteLock flag to switch between
signal to writers or signal to writers or " +
+ "reades policy.", defaults = "Default is false that means always
signal to writers")
Review comment:
Dot is unnecessary.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheOffheapManager.java
##########
@@ -122,6 +124,15 @@
* Used when persistence enabled.
*/
public class GridCacheOffheapManager extends IgniteCacheOffheapManagerImpl
implements DbCheckpointListener {
+ /** @see #WAL_MARGIN_FOR_ATOMIC_CACHE_HISTORICAL_REBALANCE */
+ public static final int
DFLT_WAL_MARGIN_FOR_ATOMIC_CACHE_HISTORICAL_REBALANCE = 5;
+
+ @SystemProperty(value = "Margin for WAL iterator, that used for historical
rebalance on atomic cache. " +
+ "It is intended for prevent partition divergence due to reordering in
WAL.", type = Long.class,
Review comment:
Dot is unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
