alex-plekhanov commented on a change in pull request #8431:
URL: https://github.com/apache/ignite/pull/8431#discussion_r526971727
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/service/ServiceInfo.java
##########
@@ -37,6 +39,9 @@
/** */
private static final long serialVersionUID = 0L;
+ /** Context. */
+ private final GridKernalContext ctx;
Review comment:
We can't get context after deserialization, because we don't know Ignite
instance at this stage. I've marked the field as transient and added a check
for null to avoid NPE. I think this is the best we can do. The class resolving
logic will not work for services with lazy configuration and deployed via
deployment SPI, after serialization/deserialization of `ServiceInfo`. But I
think it's not such a common case - `ServiceInfo` not serialized by Ignite and
serialization of `ServiceInfo` by the user looks strange. I think this class
should not be `Serializable` at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
