alex-plekhanov commented on a change in pull request #8431:
URL: https://github.com/apache/ignite/pull/8431#discussion_r534030813
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/service/ServiceInfo.java
##########
@@ -37,6 +39,9 @@
/** */
private static final long serialVersionUID = 0L;
+ /** Context. */
+ private final GridKernalContext ctx;
Review comment:
Thanks, fixed it, and added a check to the test.
I found one more problem with services using classes deployed by deployment
SPI: such services can't be deployed to the joined node. It can be reproduced
if we change in `testServiceDeploymentViaDeploymentSpi` from
`deployClusterSingleton` to `deployNodeSingleton`. We can't register class in
deployment SPI before node starts, so, after new node joins it receives
services information from the cluster and tries to start service locally, but
can't find deployment SPI classes, so a registration of such services fails.
This issue is not related to this thicket. It looks conceptual and I don't have
any ideas on how to solve it right now.
Also, looks like deployment SPI is not supported by the old service
processor implementation, so I've reverted my changes related to
GridServiceProcessor. I don't know why TC bot visa was green, I've
double-checked it manually, and test `testServiceDeploymentViaDeploymentSpi`
failed. This issue can be easily fixed, if we copy-paste `copyAndInject` method
from the new implementation, but since the old implementation is deprecated I
think we can live with these known issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
