ptupitsyn commented on a change in pull request #8635:
URL: https://github.com/apache/ignite/pull/8635#discussion_r559591660
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/PlatformJniTarget.cs
##########
@@ -309,7 +309,8 @@ private void FinishMarshal(BinaryWriter writer)
var fut = convertFunc == null && futType != FutureType.Object
? new Future<T>()
- : new Future<T>(new FutureConverter<T>(_marsh, keepBinary,
convertFunc));
+ : new Future<T>(new FutureConverter<T>(_marsh, keepBinary,
_marsh.IsRegisterSameJavaType(),
Review comment:
We pass `_marsh` to the constructor, no need to pass a property of
`_marsh` separately (here and below)
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/Marshaller.cs
##########
@@ -152,6 +159,14 @@ public ITimestampConverter TimestampConverter
get { return _cfg.TimestampConverter; }
}
+ /// <summary>
+ /// Returns register same java type flag value.
+ /// </summary>
+ public bool IsRegisterSameJavaType()
Review comment:
Nitpick: replace this method with a property
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
