nizhikov commented on a change in pull request #8635:
URL: https://github.com/apache/ignite/pull/8635#discussion_r560048124
##########
File path:
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryProcessor.cs
##########
@@ -165,41 +167,39 @@ public BinaryType RegisterEnum(string typeName,
IEnumerable<KeyValuePair<string,
/// Gets the type name by id.
/// </summary>
/// <param name="id">The identifier.</param>
+ /// <param name="registerSameJavaType">True if should register type
both for dotnet and java platforms.</param>
/// <returns>Type or null.</returns>
- public string GetTypeName(int id)
+ public string GetTypeName(int id, bool registerSameJavaType)
{
- try
+ return GetTypeName(id, DotNetPlatformId, ex =>
{
- return GetTypeName(id, DotNetPlatformId);
- }
- catch (BinaryObjectException)
- {
- if (!Marshaller.RegisterSameJavaType.Value)
- throw;
- }
+ if (!registerSameJavaType)
+ throw ex;
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
