ivandasch commented on a change in pull request #2: URL: https://github.com/apache/ignite-python-thin-client/pull/2#discussion_r561686595
########## File path: tests/test_affinity_request_routing.py ########## @@ -0,0 +1,178 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. Review comment: > How slow? Did you measure it? Tests on master more than 4 times faster than current approach. > ugly This is not a pythonic way. Pythonic way is monkey patching (so called spy) > Changing the implementation in order to test it is called "test-induced design damage" You can change method in runtime easily, please read about monkey patching. This techinque give ability to change behaviour of object in runtime without touching main code at all. ########## File path: tests/test_affinity_request_routing.py ########## @@ -0,0 +1,178 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. Review comment: > How slow? Did you measure it? Tests on master more than 4 times faster than current approach. > ugly This is not a pythonic way. Pythonic way is monkey patching (so called spy) > Changing the implementation in order to test it is called "test-induced design damage" You can change method in runtime easily, please read about monkey patching. This techinque give ability to change behaviour of object in runtime without touching main code at all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
