isapego commented on a change in pull request #2:
URL:
https://github.com/apache/ignite-python-thin-client/pull/2#discussion_r561366930
##########
File path: pyignite/connection/__init__.py
##########
@@ -131,47 +142,186 @@ def __init__(self, prefetch: bytes=b'', **kwargs):
cluster,
:param password: (optional) password to authenticate to Ignite cluster.
"""
+ self.client = client
self.prefetch = prefetch
- self._check_kwargs(kwargs)
- self.timeout = kwargs.pop('timeout', None)
- self.username = kwargs.pop('username', None)
- self.password = kwargs.pop('password', None)
- if all([self.username, self.password, 'use_ssl' not in kwargs]):
- kwargs['use_ssl'] = True
- self.init_kwargs = kwargs
-
- read_response = read_response
- _wrap = wrap
+ self.timeout = timeout
+ self.username = username
+ self.password = password
+ self._check_ssl_params(ssl_params)
+ if all([self.username, self.password, 'use_ssl' not in ssl_params]):
Review comment:
That was really weird :)
##########
File path: tests/test_affinity_request_routing.py
##########
@@ -0,0 +1,178 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Review comment:
Ivan, I believe that tests now are slower just because there are more
tests and now we start 3 to 4 nodes instead of one node before. Yeah, tests
before were faster but they covered less cases. I don't think that grepping the
log really takes a lot of time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
