timoninmaxim commented on a change in pull request #8686:
URL: https://github.com/apache/ignite/pull/8686#discussion_r573615239
##########
File path: modules/ducktests/tests/ignitetest/services/utils/control_utility.py
##########
@@ -292,11 +276,17 @@ def __run(self, cmd):
def __form_cmd(self, node, cmd):
ssl = ""
- if hasattr(self, 'key_store_path'):
- ssl = f" --keystore {self.key_store_path} --keystore-password
{self.key_store_password} " \
- f"--truststore {self.trust_store_path} --truststore-password
{self.trust_store_password}"
-
- return self._cluster.script(f"{self.BASE_COMMAND} --host
{node.account.externally_routable_ip} {cmd} {ssl}")
+ if hasattr(self.creds, 'key_store_path'):
Review comment:
As it self.creds is a class now, then it does have 'key_store_path'
attr, doesn't it? Should it to be replaced with check for None?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
