ivandasch commented on a change in pull request #8686:
URL: https://github.com/apache/ignite/pull/8686#discussion_r577506126
##########
File path: modules/ducktests/tests/ignitetest/services/utils/control_utility.py
##########
@@ -313,6 +305,33 @@ def __parse_output(raw_output):
def __alives(self):
return [node for node in self._cluster.nodes if
self._cluster.alive(node)]
+ def _parse_ssl_params(self, user, globals_dict, **kwargs):
+ ssl_dict = None
+ if globals_dict.get('use_ssl', False):
+ ssl_dict = globals_dict.get(user, {}).get('ssl', {})
+ elif kwargs.get('key_store_jks') is not None or
kwargs.get('key_store_path') is not None:
+ ssl_dict = kwargs
+ return None if ssl_dict is None else \
+ SslContextFactory(key_store_path=ssl_dict.get("key_store_path",
+ self.jks_path(
+
ssl_dict.get('key_store_jks', DEFAULT_ADMIN_KEYSTORE))),
+
key_store_password=ssl_dict.get('key_store_password', DEFAULT_PASSWORD),
+ trust_store_path=ssl_dict.get("trust_store_path",
+ self.jks_path(
+
ssl_dict.get('trust_store_jks', DEFAULT_TRUSTSTORE))),
+
trust_store_password=ssl_dict.get('trust_store_password', DEFAULT_PASSWORD))
+
+ @staticmethod
+ def _parse_creds(user, globals_dict, **kwargs):
+ creds_dict = None
+ if globals_dict.get('use_auth', False):
Review comment:
You don't need here default key, just
```
if globals_dict.get('use_auth'):
.....
elif 'login' in kwargs
....
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
