Sega76 commented on a change in pull request #8840:
URL: https://github.com/apache/ignite/pull/8840#discussion_r587869103
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/performancestatistics/PerformanceStatisticsProcessor.java
##########
@@ -214,6 +220,27 @@ public void stopCollectStatistics() throws
IgniteCheckedException {
metastorage.write(PERF_STAT_KEY, false);
}
+ /**
+ * Rotate collecting performance statistics.
+ *
+ * @throws IgniteCheckedException If rotating failed.
+ */
+ public IgniteInternalFuture<Void> rotateCollectStatistics() throws
IgniteCheckedException {
+ if (!allNodesSupports(ctx.discovery().allNodes(),
IgniteFeatures.PERFORMANCE_STATISTICS_ROTATE))
Review comment:
done
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/performancestatistics/FilePerformanceStatisticsReader.java
##########
@@ -69,15 +69,15 @@
* @see FilePerformanceStatisticsWriter
*/
public class FilePerformanceStatisticsReader {
- /** Default file read buffer size. */
- private static final int DFLT_READ_BUFFER_SIZE = (int)(8 * U.MB);
-
/** Uuid as string pattern. */
- private static final String UUID_STR_PATTERN =
+ static final String UUID_STR_PATTERN =
"[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}";
/** File name pattern. */
- private static final Pattern FILE_PATTERN = Pattern.compile("^node-(" +
UUID_STR_PATTERN + ")(-\\d+)?.prf$");
+ static final Pattern FILE_PATTERN = Pattern.compile("^node-(" +
UUID_STR_PATTERN + ")(-(\\d+))?.prf$");
+
+ /** Default file read buffer size. */
+ private static final int DFLT_READ_BUFFER_SIZE = (int)(8 * U.MB);
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
