[GitHub] [ignite] Sega76 commented on a change in pull request #8840: IGNITE-14255: Added the ability to flush all performance statistics buffers to the current file and start recording to the next file.

[GitBox]

Sega76 commented on a change in pull request #8840:
URL: https://github.com/apache/ignite/pull/8840#discussion_r597093861



##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/util/distributed/DistributedProcess.java
##########
@@ -180,7 +182,9 @@ public DistributedProcess(
                 return;
             }
 
-            finish.apply(p.id,msg.result(), msg.error());
+            finish.apply(p.id, msg.result(), msg.error());

Review comment:
       fixed

##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/performancestatistics/PerformanceStatisticsProcessor.java
##########
@@ -214,6 +234,33 @@ public void stopCollectStatistics() throws 
IgniteCheckedException {
         metastorage.write(PERF_STAT_KEY, false);
     }
 
+    /**
+     * Rotate collecting performance statistics.
+     *
+     * @throws IgniteCheckedException If rotating failed.

Review comment:
       done

##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/performancestatistics/FilePerformanceStatisticsReader.java
##########
@@ -77,7 +77,7 @@
         
"[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}";
 
     /** File name pattern. */
-    private static final Pattern FILE_PATTERN = Pattern.compile("^node-(" + 
UUID_STR_PATTERN + ")(-\\d+)?.prf$");
+    static final Pattern FILE_PATTERN = Pattern.compile("^node-(" + 
UUID_STR_PATTERN + ")(-(\\d+))?.prf$");

Review comment:
       fixed

##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/performancestatistics/PerformanceStatisticsProcessor.java
##########
@@ -278,6 +325,32 @@ private void stopWriter() {
         log.info("Performance statistics writer stopped.");
     }
 
+    /** Rotate performance statistics writer. */
+    private void rotateWriter() throws IgniteCheckedException, IOException {
+        try {
+            synchronized (mux) {
+                if (writer != null) {
+                    FilePerformanceStatisticsWriter newWriter = new 
FilePerformanceStatisticsWriter(ctx);
+
+                    newWriter.start();
+
+                    FilePerformanceStatisticsWriter oldWriter = writer;
+
+                    writer = newWriter;
+
+                    oldWriter.stop();
+                }
+            }
+
+            log.info("Performance statistics writer rotated.");

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org