sergey-chugunov-1985 commented on a change in pull request #8725:
URL: https://github.com/apache/ignite/pull/8725#discussion_r592965859
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
##########
@@ -8211,11 +8241,16 @@ public void sock(Socket sock) {
/** */
private final long failTimeNanos;
+ /** */
+ private final long initNanos;
Review comment:
Why do we need to store this value? As far as I can see we use it only
one time in constructor to add to already existing property.
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
##########
@@ -6527,6 +6504,55 @@ private void checkConnection() {
}
}
+ /**
+ * Segment local node if is being pinged while missing any outgoing ring
connection.
+ *
+ * @param skipNodes If not {@code null}, aren't taken in account when
observing nodes left in the ring.
+ */
+ private void checkOutgoingConnection(Collection<TcpDiscoveryNode>
skipNodes) {
Review comment:
It is not clear whether we should pass `skipNodes` collection to the
method parameter or obtain it under mux lock from ServerImpl.
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryImpl.java
##########
@@ -127,6 +130,13 @@
/** Tracing. */
protected Tracing tracing;
+ /**
+ * FOR TEST ONLY!!
Review comment:
I strongly don't like adding more test-only flags and methods, it is bad
approach. I believe there should be a way to simulate situation by blocking
outgoing messages without intervention into implementation internals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
