Vladsz83 commented on a change in pull request #8725:
URL: https://github.com/apache/ignite/pull/8725#discussion_r596601805



##########
File path: 
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryImpl.java
##########
@@ -127,6 +130,13 @@
     /** Tracing. */
     protected Tracing tracing;
 
+    /**
+     * FOR TEST ONLY!!

Review comment:
       Yep. We can take ServerImpl.failedNodes. Fixed.

##########
File path: 
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
##########
@@ -6527,6 +6504,55 @@ private void checkConnection() {
         }
     }
 
+    /**
+     * Segment local node if is being pinged while missing any outgoing ring 
connection.
+     *
+     * @param skipNodes If not {@code null}, aren't taken in account when 
observing nodes left in the ring.
+     */
+    private void checkOutgoingConnection(Collection<TcpDiscoveryNode> 
skipNodes) {

Review comment:
       Yep. We can take ServerImpl.failedNodes. Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to