zstan commented on a change in pull request #8837:
URL: https://github.com/apache/ignite/pull/8837#discussion_r598449781



##########
File path: 
modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerIndexForceRebuildTest.java
##########
@@ -339,9 +344,11 @@ public void testAsyncIndexesRebuild() throws 
IgniteInterruptedCheckedException {
 
     /**
      * Checks how index force rebuild command behaves when caches are under 
load.
+     *
+     * @throws Exception If failed.
      */
     @Test
-    public void testIndexRebuildUnderLoad() throws 
IgniteInterruptedCheckedException {
+    public void testIndexRebuildUnderLoad() throws Exception {

Review comment:
       1. I can`t find any indexes in test caches, did i miss something ? 
   2. Do we have any guarantee that "indexes_force_rebuild" still would be in 
progress while we calling :
   cache1.put and ignite.destroyCache(cacheName2) ? 
   3. seems we can shrink test a bit if  cahcnge :
   destroyCacheLatch.countDown(); and ignite.destroyCache(cacheName2); remove 
sleep and simple wait destroyCacheLatch ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to