zstan commented on a change in pull request #8837:
URL: https://github.com/apache/ignite/pull/8837#discussion_r598470572



##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/query/schema/SchemaIndexCachePartitionWorker.java
##########
@@ -191,7 +192,10 @@ private void processPartition() throws 
IgniteCheckedException {
                         locked = false;
                     }
 
-                    cctx.cache().metrics0().addIndexRebuildKeyProcessed(1);
+                    GridCacheAdapter cache = cctx.cache();

Review comment:
       as i can see you already check cctx.cache() != null in 
SchemaIndexCachePartitionWorker#stop, why do we need additional check here ? + 
If we can obtain invariant that SchemaIndexCachePartitionWorker still in 
progress and GridCacheAdapter cache = cctx.cache(); cache **==** null we still 
can obtain flaky test, isn`t it ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to