ibessonov commented on a change in pull request #76:
URL: https://github.com/apache/ignite-3/pull/76#discussion_r605442591
##########
File path:
modules/configuration-annotation-processor/src/main/java/org/apache/ignite/configuration/processor/internal/Processor.java
##########
@@ -394,8 +393,8 @@ private ConfigurationFieldTypes getTypes(final
VariableElement field) {
final Value valueAnnotation = field.getAnnotation(Value.class);
if (valueAnnotation != null) {
- ClassName dynPropClass = ClassName.get(DynamicProperty.class);
- ClassName confValueClass = ClassName.get(ConfigurationValue.class);
+ ClassName dynPropClass =
ClassName.get("org.apache.ignite.configuration.internal", "DynamicProperty");
Review comment:
Because I kept getting "NoClassDefFoundError" from that damn
ITProcessorTest and this turned out to be the only way to fix it.
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/configuration/ConfigurationRegistry.java
##########
@@ -113,6 +124,38 @@ public void registerStorage(ConfigurationStorage
configurationStorage) {
return changer.changeX(path, changesSource, storage);
}
+ /** */
+ public void stop() {
+ changer.stop();
+ }
+
+ /** */
+ private @NotNull CompletableFuture<?> notificator(SuperRoot oldSuperRoot,
SuperRoot newSuperRoot, long storageRevision) {
+ List<CompletableFuture<?>> futures = new ArrayList<>();
+
+ newSuperRoot.traverseChildren(new ConfigurationVisitor<Void>() {
+ @Override public Void visitInnerNode(String key, InnerNode
newRoot) {
+ InnerNode oldRoot = oldSuperRoot.traverseChild(key,
innerNodeVisitor());
+
+ var cfg = (DynamicConfiguration<InnerNode, ?,
?>)configs.get(key);
+
+ assert oldRoot != null && cfg != null : key;
+
+ if (oldRoot != newRoot)
+ notifyListeners(oldRoot, newRoot, cfg, storageRevision,
futures);
+
+ return null;
+ }
+ });
+
+ return CompletableFuture.allOf(futures.stream().map(listenerFut ->
listenerFut.handle((res, throwable) -> {
Review comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
