ibessonov commented on a change in pull request #76:
URL: https://github.com/apache/ignite-3/pull/76#discussion_r605452851
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/configuration/ConfigurationChanger.java
##########
@@ -200,6 +224,11 @@ public void initialize(Class<? extends
ConfigurationStorage> storageType) {
return change(superRoot, storage.getClass());
}
+ /** Stop component. */
+ public void stop() {
+ pool.shutdownNow();
Review comment:
I know, right now it only prevents thread leaks in tests. Given that we
don't have any lifecycle for our components, I'm not sure about what we should
really do here. Ideally we should at least complete all the pending futures :)
Let's do it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
