sashapolo commented on a change in pull request #76:
URL: https://github.com/apache/ignite-3/pull/76#discussion_r605462825
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/configuration/ConfigurationChanger.java
##########
@@ -86,8 +100,18 @@ private StorageRoots(SuperRoot roots, long version) {
/** Storage instances by their classes. Comes in handy when all you have
is {@link RootKey}. */
private final Map<Class<? extends ConfigurationStorage>,
ConfigurationStorage> storageInstances = new HashMap<>();
- /** Constructor. */
- public ConfigurationChanger(RootKey<?, ?>... rootKeys) {
+ /**
+ * @param notificator Closure to execute when update forom storage is
received.
+ */
+ public ConfigurationChanger(Notificator notificator) {
+ this.notificator = notificator;
+ }
+
+ /** Constructor for tests. */
+ @TestOnly
+ ConfigurationChanger(RootKey<?, ?>... rootKeys) {
Review comment:
I mean, can this constructor be extracted as a factory method in some
test class instead of polluting the API of this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
