ibessonov commented on a change in pull request #76:
URL: https://github.com/apache/ignite-3/pull/76#discussion_r606121839



##########
File path: 
modules/configuration/src/main/java/org/apache/ignite/configuration/ConfigurationChanger.java
##########
@@ -50,7 +54,7 @@
 /**
  * Class that handles configuration changes, by validating them, passing to 
storage and listening to storage updates.
  */
-public class ConfigurationChanger {
+public final class ConfigurationChanger {
     /** */
     private final ForkJoinPool pool = new ForkJoinPool(2);

Review comment:
       Well, what's the reason behind changing it then? Right now I see no pros 
and cons for both options)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to