sashapolo commented on a change in pull request #76:
URL: https://github.com/apache/ignite-3/pull/76#discussion_r606167400
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/configuration/ConfigurationChanger.java
##########
@@ -50,7 +54,7 @@
/**
* Class that handles configuration changes, by validating them, passing to
storage and listening to storage updates.
*/
-public class ConfigurationChanger {
+public final class ConfigurationChanger {
/** */
private final ForkJoinPool pool = new ForkJoinPool(2);
Review comment:
There's no need in doing that, especially in this PR. My only concern is
that `ForkJoinPool` is intended to be used with a special type of tasks, which
we are not doing here, so this code might be confusing for future generations
(as it has already confused me)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
