korlov42 commented on a change in pull request #9009:
URL: https://github.com/apache/ignite/pull/9009#discussion_r617454579
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/MinusNode.java
##########
@@ -112,6 +112,14 @@ public void end(int idx) throws Exception {
checkState();
+ if (type == AggregateType.SINGLE && grouping.isEmpty()) {
+ requested = 0;
+
+ downstream().end();
Review comment:
Subsequent ending of downstream is unwanted because you have to be sure
a caller side is waiting for next row. Currently it will be violated in case
underlying source is empty, and caller invokes `request(0)`. This case is
syntetic right now, yet still possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
