alex-plekhanov commented on a change in pull request #9009:
URL: https://github.com/apache/ignite/pull/9009#discussion_r616393789
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/RowHandler.java
##########
@@ -40,6 +40,9 @@
/** */
int columnCount(Row row);
+ /** */
+ Object[] getColumns(Row row);
Review comment:
> Please don't be fooled by the fact we have only one row representation
-- array of object.
There can be any row representation. As far as `RowHandler` can return
`Object` by the index of column and count of columns it can return `Object[]` -
the array of columns values as well. The `getColumns()` method of `RowHandler`
doesn't mean "give me internals of row", it means "make an array from columns
values", but in some cases (`ArrayRowHandler`) it can be optimized and return
just internals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
