sanpwc commented on a change in pull request #103:
URL: https://github.com/apache/ignite-3/pull/103#discussion_r620052180
##########
File path:
modules/affinity/src/main/java/org/apache/ignite/internal/affinity/AffinityManager.java
##########
@@ -52,9 +72,121 @@ public AffinityManager(
this.configurationMgr = configurationMgr;
this.metaStorageMgr = metaStorageMgr;
this.baselineMgr = baselineMgr;
+
+ String localNodeName =
configurationMgr.configurationRegistry().getConfiguration(NetworkConfiguration.KEY)
+ .name().value();
+
+
configurationMgr.configurationRegistry().getConfiguration(LocalConfiguration.KEY)
+ .metastorageMembers().listen(ctx -> {
+ if (ctx.newValue() != null) {
+ if (hasMetastorageLocally(localNodeName, ctx.newValue()))
+ subscribeToAssignmentCalculation();
+ else
+ unsubscribeFromAssignmentCalculation();
+ }
+ return CompletableFuture.completedFuture(null);
+ });
+
+ String[] metastorageMembers =
configurationMgr.configurationRegistry().getConfiguration(LocalConfiguration.KEY)
+ .metastorageMembers().value();
+
+ if (hasMetastorageLocally(localNodeName, metastorageMembers))
+ subscribeToAssignmentCalculation();
}
- // TODO: IGNITE-14237 Affinity function.
- // TODO: IGNITE-14238 Creating and destroying caches.
- // TODO: IGNITE-14235 Provide a minimal cache/table configuration.
+ /**
+ * Tests a node has a involved into Metastorage.
Review comment:
Checks instead of tests.
Typo "a".
All in all, I'd rather use something similar to: "Checks whether local node
hosts Metastorage." Up to you.
##########
File path:
modules/affinity/src/main/java/org/apache/ignite/internal/affinity/AffinityManager.java
##########
@@ -17,15 +17,34 @@
package org.apache.ignite.internal.affinity;
-import org.apache.ignite.internal.baseline.BaselineManager;
+import java.nio.charset.StandardCharsets;
+import java.util.UUID;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
import org.apache.ignite.configuration.internal.ConfigurationManager;
+import org.apache.ignite.configuration.schemas.network.NetworkConfiguration;
+import org.apache.ignite.configuration.schemas.runner.LocalConfiguration;
+import org.apache.ignite.configuration.schemas.table.TablesConfiguration;
+import org.apache.ignite.internal.baseline.BaselineManager;
import org.apache.ignite.internal.metastorage.MetaStorageManager;
+import org.apache.ignite.internal.util.ArrayUtils;
+import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.lang.IgniteLogger;
+import org.apache.ignite.metastorage.common.Key;
+import org.apache.ignite.metastorage.common.WatchEvent;
+import org.apache.ignite.metastorage.common.WatchListener;
+import org.jetbrains.annotations.NotNull;
/**
* Affinity manager is responsible for affinity function related logic
including calculating affinity assignments.
*/
-// TODO: IGNITE-14586 Remove @SuppressWarnings when implementation provided.
-@SuppressWarnings({"FieldCanBeLocal", "unused"}) public class AffinityManager {
+public class AffinityManager {
+ /** The logger. */
+ private static final IgniteLogger LOG =
IgniteLogger.forClass(AffinityManager.class);
+
+ /** Tables prefix for the metasorage. */
+ public static final String INTERNAL_PREFIX = "internal.tables.";
Review comment:
private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
