sanpwc commented on a change in pull request #103:
URL: https://github.com/apache/ignite-3/pull/103#discussion_r620189527
##########
File path: modules/api/src/main/java/org/apache/ignite/app/Ignite.java
##########
@@ -29,4 +30,11 @@
* @return Table manager.
*/
TableManager tableManager();
+
+ /**
+ * Gets interactive object for configure cluster.
+ *
+ * @return Ignite configuration.
+ */
+ ConfigurationRegistry configuration();
Review comment:
It's not valid to use ConfigurationRegistry as public API, cause it's
located in inner configuration module. Semantically we need some new
ConfigurationRegistry interface, locates in ignite-api module, that will have
only subset of current ConfigurationRegistry methods, for example we don't need
startStorageConfigurations(), constructors, etc as part of public API. It also
means that we should rename ConfigurationRegistry to ConfigurationRegistryImpl
or similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
