korlov42 commented on a change in pull request #9085:
URL: https://github.com/apache/ignite/pull/9085#discussion_r630910213
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/trait/CorrelationTrait.java
##########
@@ -92,7 +92,12 @@ public boolean correlated() {
if (trait == this || this == UNCORRELATED)
return true;
- return equals(trait);
+ if (!(trait instanceof CorrelationTrait))
+ return false;
+
+ CorrelationTrait other = (CorrelationTrait) trait;
+
+ return other.correlated() &&
other.correlationIds().containsAll(correlationIds());
Review comment:
> But such spool should require input correlated by cor1
Probably this is the key. Currently a spool just takes an input as is.
Am I right that you suggest to interpret correlation not as "the real
correlation of the stream", but "the stream is correlated at most by this
corrSet"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
