alex-plekhanov commented on a change in pull request #9085:
URL: https://github.com/apache/ignite/pull/9085#discussion_r630919707
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/trait/CorrelationTrait.java
##########
@@ -92,7 +92,12 @@ public boolean correlated() {
if (trait == this || this == UNCORRELATED)
return true;
- return equals(trait);
+ if (!(trait instanceof CorrelationTrait))
+ return false;
+
+ CorrelationTrait other = (CorrelationTrait) trait;
+
+ return other.correlated() &&
other.correlationIds().containsAll(correlationIds());
Review comment:
> but "the stream is correlated at most by this corrSet"?
Yes. I thought that it works currently such a way (since UNCORRELATED
satisfy any correlation and filter passes correlation if this correlation
contains a superset of required by filter variables)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
