AMashenkov commented on a change in pull request #91:
URL: https://github.com/apache/ignite-3/pull/91#discussion_r634279782
##########
File path:
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
##########
@@ -200,12 +199,12 @@ private void listenForTableChange() {
if (hasMetastorageLocally) {
var key = new Key(INTERNAL_PREFIX + tblId.toString());
-
futs.add(metaStorageMgr.invoke(
Conditions.key(key).value().eq(null),
Operations.put(key,
tableView.name().getBytes(StandardCharsets.UTF_8)),
- Operations.noop()).thenCompose(res ->
- affMgr.calculateAssignments(tblId)));
+ Operations.noop())
+ .thenCompose(res ->
schemaMgr.initNewSchemaForTable(tblId, tableView.name()))
Review comment:
How are you suggest to synchronize 2 independent async events? e.g.
Schema.REMOVED and Affinity.REMOVED.
Why you decide Affinity.REMOVED is terminal event for Table.drop() operation?
Is there any explanation or decision how components should communicate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
