AMashenkov commented on a change in pull request #91:
URL: https://github.com/apache/ignite-3/pull/91#discussion_r634282374
##########
File path:
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
##########
@@ -200,12 +199,12 @@ private void listenForTableChange() {
if (hasMetastorageLocally) {
var key = new Key(INTERNAL_PREFIX + tblId.toString());
-
futs.add(metaStorageMgr.invoke(
Conditions.key(key).value().eq(null),
Operations.put(key,
tableView.name().getBytes(StandardCharsets.UTF_8)),
- Operations.noop()).thenCompose(res ->
- affMgr.calculateAssignments(tblId)));
+ Operations.noop())
+ .thenCompose(res ->
schemaMgr.initNewSchemaForTable(tblId, tableView.name()))
Review comment:
For now I see the construction "affMgr.listen(AffinityEvent.REMOVED,
...)" which semantic is unclear and it has a bug.
If user will start/stop tables, affMgr.listeners collection will constantly
grows, as noone removes useless listeners from it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
