nizhikov commented on a change in pull request #8909: URL: https://github.com/apache/ignite/pull/8909#discussion_r637963017
########## File path: modules/core/src/main/java/org/apache/ignite/cdc/ChangeDataCaptureConfiguration.java ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.cdc; + +import org.apache.ignite.configuration.DataStorageConfiguration; +import org.apache.ignite.internal.cdc.ChangeDataCapture; +import org.apache.ignite.lang.IgniteExperimental; + +/** + * This class defines {@link ChangeDataCapture} runtime configuration. + * This configuration is passed to {@link ChangeDataCapture} constructor. + * It defines all configuration + */ +@IgniteExperimental +public class ChangeDataCaptureConfiguration { + /** */ + private static final int DFLT_LOCK_TIMEOUT = 1000; + + /** */ + private static final long DFLT_CHECK_FREQ = 1000L; + + /** */ + private static final boolean DFLT_KEEP_BINARY = true; Review comment: Yes, we need it for the SQL CDC use-cases or when we want a dynamic cache structureŃ > we need a test to confirm this flag is useful when it true Please, take a look into `SQLChangeDataCaptureTest` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
