alex-plekhanov commented on a change in pull request #9095:
URL: https://github.com/apache/ignite/pull/9095#discussion_r640652561
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rel/set/IgniteSetOp.java
##########
@@ -19,71 +19,47 @@
import java.util.List;
import com.google.common.collect.ImmutableList;
-import org.apache.calcite.plan.RelOptCluster;
import org.apache.calcite.plan.RelOptCost;
import org.apache.calcite.plan.RelOptPlanner;
import org.apache.calcite.plan.RelTraitSet;
import org.apache.calcite.rel.RelCollations;
-import org.apache.calcite.rel.RelInput;
import org.apache.calcite.rel.RelNode;
-import org.apache.calcite.rel.core.Minus;
import org.apache.calcite.rel.metadata.RelMetadataQuery;
import org.apache.calcite.util.Pair;
+import
org.apache.ignite.internal.processors.query.calcite.exec.exp.agg.AggregateType;
import
org.apache.ignite.internal.processors.query.calcite.metadata.cost.IgniteCost;
import
org.apache.ignite.internal.processors.query.calcite.metadata.cost.IgniteCostFactory;
-import
org.apache.ignite.internal.processors.query.calcite.rel.IgniteConvention;
-import org.apache.ignite.internal.processors.query.calcite.trait.TraitUtils;
import
org.apache.ignite.internal.processors.query.calcite.trait.TraitsAwareIgniteRel;
import org.apache.ignite.internal.processors.query.calcite.util.Commons;
/**
- * Base class for physical MINUS (EXCEPT) set op.
+ * Base interface for physical set op node (MINUS, INTERSECT).
*/
-public abstract class IgniteMinusBase extends Minus implements
TraitsAwareIgniteRel {
- /** Count of counter fields used to aggregate results. */
- protected static final int COUNTER_FIELDS_CNT = 2;
-
- /** */
- IgniteMinusBase(RelOptCluster cluster, RelTraitSet traits, List<RelNode>
inputs, boolean all) {
- super(cluster, traits, inputs, all);
- }
-
- /** {@inheritDoc} */
- protected IgniteMinusBase(RelInput input) {
- super(TraitUtils.changeTraits(input, IgniteConvention.INSTANCE));
- }
+public interface IgniteSetOp extends TraitsAwareIgniteRel {
+ /** ALL flag of set op. */
+ public boolean all();
/** {@inheritDoc} */
- @Override public Pair<RelTraitSet, List<RelTraitSet>>
passThroughCollation(RelTraitSet nodeTraits, List<RelTraitSet> inputTraits) {
+ @Override public default Pair<RelTraitSet, List<RelTraitSet>>
passThroughCollation(RelTraitSet nodeTraits,
+ List<RelTraitSet> inputTraits) {
// Operation erases collation.
return Pair.of(nodeTraits.replace(RelCollations.EMPTY),
Commons.transform(inputTraits, t ->
t.replace(RelCollations.EMPTY)));
}
/** {@inheritDoc} */
- @Override public List<Pair<RelTraitSet, List<RelTraitSet>>>
deriveCollation(RelTraitSet nodeTraits, List<RelTraitSet> inputTraits) {
+ @Override public default List<Pair<RelTraitSet, List<RelTraitSet>>>
deriveCollation(RelTraitSet nodeTraits,
+ List<RelTraitSet> inputTraits) {
// Operation erases collation.
return
ImmutableList.of(Pair.of(nodeTraits.replace(RelCollations.EMPTY),
Commons.transform(inputTraits, t ->
t.replace(RelCollations.EMPTY))));
}
/** Gets count of fields for aggregation for this node. Required for
memory consumption calculation. */
- protected abstract int aggregateFieldsCount();
-
- /** {@inheritDoc} */
- @Override public double estimateRowCount(RelMetadataQuery mq) {
- final List<RelNode> inputs = getInputs();
-
- double rows = mq.getRowCount(inputs.get(0));
-
- for (int i = 1; i < inputs.size(); i++)
- rows -= 0.5 * Math.min(rows, mq.getRowCount(inputs.get(i)));
-
- return rows;
- }
+ public int aggregateFieldsCount();
/** {@inheritDoc} */
- @Override public RelOptCost computeSelfCost(RelOptPlanner planner,
RelMetadataQuery mq) {
+ @Override public default RelOptCost computeSelfCost(RelOptPlanner planner,
RelMetadataQuery mq) {
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
