alex-plekhanov commented on a change in pull request #9095: URL: https://github.com/apache/ignite/pull/9095#discussion_r640670389
########## File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rel/set/IgniteReduceIntersect.java ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.query.calcite.rel.set; + +import java.util.List; +import com.google.common.collect.ImmutableList; +import org.apache.calcite.plan.RelOptCluster; +import org.apache.calcite.plan.RelTraitSet; +import org.apache.calcite.rel.RelInput; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.RelWriter; +import org.apache.calcite.rel.core.SetOp; +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.sql.SqlExplainLevel; +import org.apache.ignite.internal.processors.query.calcite.rel.IgniteConvention; +import org.apache.ignite.internal.processors.query.calcite.rel.IgniteRel; +import org.apache.ignite.internal.processors.query.calcite.rel.IgniteRelVisitor; + +/** + * Physical node for REDUCE phase of INTERSECT operator. + */ +public class IgniteReduceIntersect extends IgniteIntersect implements IgniteReduceSetOp { + /** */ + public IgniteReduceIntersect( + RelOptCluster cluster, + RelTraitSet traitSet, + RelNode input, + boolean all, + RelDataType rowType + ) { + super(cluster, traitSet, ImmutableList.of(input), all); + + this.rowType = rowType; + } + + /** */ + public IgniteReduceIntersect(RelInput input) { + this( + input.getCluster(), + input.getTraitSet().replace(IgniteConvention.INSTANCE), + input.getInput(), + input.getBoolean("all", false), + input.getRowType("rowType") + ); + } + + /** {@inheritDoc} */ + @Override public RelWriter explainTerms(RelWriter pw) { + super.explainTerms(pw) + .itemIf("rowType", rowType, pw.getDetailLevel() == SqlExplainLevel.ALL_ATTRIBUTES); + + return pw; + } + + /** {@inheritDoc} */ + @Override public SetOp copy(RelTraitSet traitSet, List<RelNode> inputs, boolean all) { + return new IgniteReduceIntersect(getCluster(), traitSet, sole(inputs), all, rowType); + } + + /** {@inheritDoc} */ + @Override public IgniteReduceIntersect clone(RelOptCluster cluster, List<IgniteRel> inputs) { + return new IgniteReduceIntersect(cluster, getTraitSet(), sole(inputs), all, rowType); + } + + /** {@inheritDoc} */ + @Override public <T> T accept(IgniteRelVisitor<T> visitor) { + return visitor.visit(this); + } + + /** {@inheritDoc} */ + @Override public int aggregateFieldsCount() { + return rowType.getFieldCount() + 2 /* At least two fields required for count aggregation. */; Review comment: I think it's not so important to have exact fields count here, some approximation will be enough (we should pass inputs count to the constructor and store it only for exact calculation). We already have a very rough estimation here, so having exact counter size doesn't make memory cost precise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
