ibessonov commented on a change in pull request #153:
URL: https://github.com/apache/ignite-3/pull/153#discussion_r643840482
##########
File path:
modules/network/src/main/java/org/apache/ignite/network/internal/direct/stream/DirectByteBufferStreamImplV1.java
##########
@@ -1029,15 +1032,22 @@ public
DirectByteBufferStreamImplV1(MessageSerializationRegistry serializationRe
/** {@inheritDoc} */
@Override public <T extends NetworkMessage> T readMessage(MessageReader
reader) {
if (!msgTypeDone) {
- if (buf.remaining() < NetworkMessage.DIRECT_TYPE_SIZE) {
+ if (buf.remaining() < NetworkMessage.MSG_TYPE_SIZE_BYTES) {
lastFinished = false;
return null;
}
- short type = readShort();
+ short messageGroupType = readShort();
- msgDeserializer = type == Short.MIN_VALUE ? null :
serializationRegistry.createDeserializer(type);
+ if (messageGroupType == Short.MIN_VALUE) {
+ msgDeserializer = null;
+ }
Review comment:
Extra braces :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
