sashapolo commented on a change in pull request #153:
URL: https://github.com/apache/ignite-3/pull/153#discussion_r643857194
##########
File path:
modules/network/src/main/java/org/apache/ignite/network/internal/direct/DirectMarshallingUtils.java
##########
@@ -18,31 +18,33 @@
package org.apache.ignite.network.internal.direct;
import java.nio.ByteBuffer;
+import org.apache.ignite.network.internal.direct.stream.DirectByteBufferStream;
/**
* Direct marshalling utils.
*/
public class DirectMarshallingUtils {
/**
- * Reads a direct message type from a byte buffer.
+ * Reads a {@code short} from a byte buffer in an order defined by the
{@link DirectByteBufferStream}
+ * implementation.
*
* @param buffer Byte buffer.
* @return Direct message type.
*/
- public static short getMessageType(ByteBuffer buffer) {
+ public static short getShort(ByteBuffer buffer) {
byte b0 = buffer.get();
Review comment:
but we will need to implement compression on the writing side as well,
won't we? And I will have to write tests for that. Can we do it as a separate
task, I'm afraid this PR is already too big?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
