sanpwc commented on a change in pull request #160:
URL: https://github.com/apache/ignite-3/pull/160#discussion_r646340471
##########
File path:
modules/runner/src/main/java/org/apache/ignite/internal/storage/DistributedConfigurationStorage.java
##########
@@ -235,17 +236,17 @@ public DistributedConfigurationStorage(MetaStorageManager
metaStorageMgr) {
}
/**
- * Method that returns all distributed configuration keys from meta
storage filtered out by the current applied
- * revision as an upper bound. Applied revision is a revision of the last
successful vault update.
+ * Method that returns all distributed configuration keys from meta
storage that were stored in vault filtered out by the
+ * current applied revision as an upper bound. Applied revision is a
revision of the last successful vault update.
* <p>
* This is possible to distinguish cfg keys from meta storage because we
add special prefix {@link
- * DistributedConfigurationStorage#DISTRIBUTED_PREFIX} to all
configuration keys that we put to meta storage.
+ * MetaStorageManager#DISTRIBUTED_PREFIX} to all configuration keys that
we put to meta storage.
*
- * @return Cursor built upon all distributed configuration entries.
+ * @return Iterator built upon all distributed configuration entries
stored in vault.
*/
- private Cursor<Entry> allDistributedConfigKeys() {
+ private @NotNull Iterator<org.apache.ignite.internal.vault.common.Entry>
allStoredDstCfgKeysFromVault() {
Review comment:
It's not valid to use abbreviations in method names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
