alievmirza commented on a change in pull request #160:
URL: https://github.com/apache/ignite-3/pull/160#discussion_r648934523
##########
File path:
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java
##########
@@ -161,14 +176,22 @@ public MetaStorageManager(
public synchronized void deployWatches() {
try {
var watch = watchAggregator.watch(
- vaultMgr.appliedRevision() + 1,
+ appliedRevision() + 1,
this::storeEntries
);
if (watch.isEmpty())
deployFut.complete(Optional.empty());
- else
- dispatchAppropriateMetaStorageWatch(watch.get()).thenAccept(id
-> deployFut.complete(Optional.of(id))).join();
+ else {
+ CompletableFuture<Void> fut =
+
dispatchAppropriateMetaStorageWatch(watch.get()).thenAccept(id ->
deployFut.complete(Optional.of(id)));
Review comment:
out of scope
##########
File path:
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java
##########
@@ -161,14 +176,22 @@ public MetaStorageManager(
public synchronized void deployWatches() {
try {
var watch = watchAggregator.watch(
- vaultMgr.appliedRevision() + 1,
+ appliedRevision() + 1,
this::storeEntries
);
if (watch.isEmpty())
deployFut.complete(Optional.empty());
- else
- dispatchAppropriateMetaStorageWatch(watch.get()).thenAccept(id
-> deployFut.complete(Optional.of(id))).join();
+ else {
+ CompletableFuture<Void> fut =
+
dispatchAppropriateMetaStorageWatch(watch.get()).thenAccept(id ->
deployFut.complete(Optional.of(id)));
+
+ if (metaStorageNodesOnStart)
+ fut.join();
Review comment:
out of scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
