ptupitsyn commented on a change in pull request #191: URL: https://github.com/apache/ignite-3/pull/191#discussion_r674792547
########## File path: modules/client-common/src/main/java/org/apache/ignite/client/ClientMsgPackType.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.client; + +/** + * Ignite-specific extension type codes. Review comment: > why these types are in separate class Where would you put them? Those constants are used by `ClientMessagePacker` and `ClientMessageUnpacker`. > these codes uses are registered/used in kind of extended type system inside MsgPack Please see UUID pack/unpack as an example. MsgPack allows up to 128 custom extension types, identified by a `byte`. It is up to the users (us) to assign those numbers any way we want. There is no "registration", we simply say `packExtensionTypeHeader(code, size)` and then add arbitrary payload. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
