ptupitsyn commented on a change in pull request #191: URL: https://github.com/apache/ignite-3/pull/191#discussion_r674821108
########## File path: modules/client-common/src/main/java/org/apache/ignite/client/ClientMessageUnpacker.java ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.client; + +import org.apache.ignite.lang.IgniteException; +import org.msgpack.core.MessagePack; +import org.msgpack.core.MessageSizeException; +import org.msgpack.core.MessageTypeException; +import org.msgpack.core.MessageUnpacker; +import org.msgpack.core.buffer.MessageBufferInput; + +import java.io.IOException; +import java.math.BigDecimal; +import java.nio.ByteBuffer; +import java.nio.ByteOrder; +import java.util.BitSet; +import java.util.UUID; + +import static org.apache.ignite.client.ClientDataType.BITMASK; +import static org.apache.ignite.client.ClientDataType.BYTES; +import static org.apache.ignite.client.ClientDataType.DECIMAL; +import static org.apache.ignite.client.ClientDataType.DOUBLE; +import static org.apache.ignite.client.ClientDataType.FLOAT; +import static org.apache.ignite.client.ClientDataType.INT16; +import static org.apache.ignite.client.ClientDataType.INT32; +import static org.apache.ignite.client.ClientDataType.INT64; +import static org.apache.ignite.client.ClientDataType.INT8; +import static org.apache.ignite.client.ClientDataType.STRING; + +/** + * Ignite-specific MsgPack extension. + */ +public class ClientMessageUnpacker extends MessageUnpacker { + /** + * Constructor. + * + * @param in Input. + */ + public ClientMessageUnpacker(MessageBufferInput in) { + super(in, MessagePack.DEFAULT_UNPACKER_CONFIG); + } + + /** + * Reads an UUID. + * + * @return UUID value. + * @throws IOException when underlying input throws IOException. + * @throws MessageTypeException when type is not UUID. + * @throws MessageSizeException when size is not correct. + */ + public UUID unpackUuid() throws IOException { + var hdr = unpackExtensionTypeHeader(); + var type = hdr.getType(); + var len = hdr.getLength(); Review comment: We don't write it or read it. `fixext 16` (one byte header) type is used underneath automatically when extension payload is 16 bytes. https://github.com/msgpack/msgpack/blob/master/spec.md#ext-format-family -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
