Vladsz83 commented on a change in pull request #9313:
URL: https://github.com/apache/ignite/pull/9313#discussion_r701753467



##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/managers/encryption/GridEncryptionManager.java
##########
@@ -1517,6 +1525,12 @@ public void 
applyReencryptionStartRecord(ReencryptionStartRecord rec) {
                 "The previous change was not completed."));
         }
 
+        if (ctx.cache().context().snapshotMgr().isSnapshotCreating()

Review comment:
       Master key change and snapshots are distributed processes based on 
discovery messages which are guaranteed be sequential. Once one process is 
active, another process will see this state. There is no pure concurrency. 
Master key change isn't allowed during snapshot. Snapshot is not allowed during 
master key change and re-encryption. You can check ` 
testSnapshotFailsDuringCacheKeyChange()`, ` 
testSnapshotFailsDuringMasterKeyChange()`, ` 
testMasterKeyChangeDuringSnapshot()`, ` testMasterKeyChangeDuringRestore()`, ` 
testReencryptionDuringRestore()`, ` testReencryptionDuringSnapshot()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to