Vladsz83 commented on a change in pull request #9313:
URL: https://github.com/apache/ignite/pull/9313#discussion_r701746483



##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java
##########
@@ -597,6 +606,12 @@ public File snapshotTmpDir() {
                 "prior to snapshot operation start: " + leftNodes));
         }
 
+        if (!cctx.localNode().isClient() && 
cctx.kernalContext().encryption().isMasterKeyChangeInProgress()

Review comment:
       I don't think so. We do not affect snapshot-on-client behavior in this 
ticket. It has been working well till now. Shapshots-on-client hasn't raised 
NPE before the ticket. I believe, because this DistributedProcess doesn't work 
on client regardless encrypted or not. There is 
`cctx.kernalContext().clientNode()` before. It hasn't been asserted earlier. I 
don't think we should care.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to