korlov42 commented on a change in pull request #9369:
URL: https://github.com/apache/ignite/pull/9369#discussion_r702870476
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/Fragment.java
##########
@@ -121,15 +122,8 @@ public boolean rootFragment() {
}
/** */
- public Fragment attach(PlanningContext ctx) {
- RelOptCluster cluster = ctx.cluster();
-
- return root.getCluster() == cluster ? this : new
Cloner(cluster).go(this);
- }
-
- /** */
- public Fragment detach() {
- RelOptCluster cluster = PlanningContext.empty().cluster();
+ public Fragment copy() {
+ RelOptCluster cluster = Commons.cluster();
return root.getCluster() == cluster ? this : new
Cloner(cluster).go(this);
Review comment:
To preserve the old semantic we need to do a deep copy unconditionally
now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
