korlov42 commented on a change in pull request #9369:
URL: https://github.com/apache/ignite/pull/9369#discussion_r702871674



##########
File path: 
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/Fragment.java
##########
@@ -139,7 +133,7 @@ public Fragment detach() {
      * @param ctx Planner context.
      * @param mq Metadata query.
      */
-    Fragment map(MappingService mappingSrvc, PlanningContext ctx, 
RelMetadataQuery mq) throws FragmentMappingException {
+    Fragment map(MappingService mappingSrvc, MappingQueryContext ctx, 
RelMetadataQuery mq) throws FragmentMappingException {
         assert root.getCluster() == ctx.cluster() : "Fragment is detached 
[fragment=" + this + "]";

Review comment:
       currently this assertion will be always true, hence, probably, it's 
better to remove it. This allows us to remove `cluster` from a 
MappingQueryContext since this place is the only usage 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to