sanpwc commented on a change in pull request #321:
URL: https://github.com/apache/ignite-3/pull/321#discussion_r704001535
##########
File path:
modules/raft/src/main/java/org/apache/ignite/raft/jraft/entity/PeerId.java
##########
@@ -287,6 +287,9 @@ else if (!this.endpoint.equals(other.endpoint)) {
}
public static PeerId fromPeer(Peer p) {
Review comment:
It's look like a factory method, so it's confusing that it could produce
null.
Are there any use-cases of null p Peer?
In any case lets add javadoc and @Nullable/@NotNull annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
